Skip to content

Remove deprecated ServerAddress methods#1224

Merged
jyemin merged 4 commits into
mongodb:5.xfrom
jyemin:j4937
Oct 21, 2023
Merged

Remove deprecated ServerAddress methods#1224
jyemin merged 4 commits into
mongodb:5.xfrom
jyemin:j4937

Conversation

@jyemin

@jyemin jyemin commented Oct 17, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • ServerAddress#getSocketAddress
  • ServerAddress#getSocketAddresses
  • UnixServerAddress#getSocketAddress
  • UnixServerAddress#getUnixSocketAddress

JAVA-4937

Design Notes:

  • Delete ServerAddressWithResolver and instead push the InetAddressResolver down to the Stream implementations
  • Add internal DefaultInetAddressResolver to replicate the removed ServerAddress method and avoid having to make the resolver nullable everywhere

@jyemin
Remove deprecated ServerAddress methods
65eda8a 
* ServerAddress#getSocketAddress
* ServerAddress#getSocketAddresses
* UnixServerAddress#getSocketAddress
* UnixServerAddress#getUnixSocketAddress

JAVA-4937
@jyemin jyemin self-assigned this Oct 17, 2023
jyemin
jyemin commented Oct 17, 2023
View reviewed changes
Comment thread driver-core/src/main/com/mongodb/internal/connection/ServerAddressHelper.java
@jyemin jyemin requested a review from stIncMale October 17, 2023 23:32
stIncMale
stIncMale requested changes Oct 20, 2023
View reviewed changes
Comment thread driver-core/src/main/com/mongodb/internal/connection/netty/NettyStreamFactoryFactory.java Outdated
Comment thread driver-core/src/test/unit/com/mongodb/internal/connection/ConnectionPoolAsyncTest.java Outdated
Comment thread driver-core/src/test/unit/com/mongodb/internal/connection/StreamFactoryHelperTest.java Outdated
Comment thread driver-core/src/test/functional/com/mongodb/connection/netty/NettyStreamSpecification.groovy
jyemin and others added 2 commits October 20, 2023 10:33
@jyemin @stIncMale
Update driver-core/src/test/unit/com/mongodb/internal/connection/Conn…
de66bf4 
…ectionPoolAsyncTest.java

Co-authored-by: Valentin Kovalenko <valentin.male.kovalenko@gmail.com>
@jyemin
Update tests
8b20ed9
jyemin
jyemin commented Oct 20, 2023
View reviewed changes

@jyemin jyemin left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch build: https://spruce.mongodb.com/version/6532d61757e85a1ab0fcf729/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC

Comment thread driver-core/src/main/com/mongodb/internal/connection/netty/NettyStreamFactoryFactory.java Outdated
Comment thread driver-core/src/test/unit/com/mongodb/internal/connection/StreamFactoryHelperTest.java Outdated
Comment thread driver-core/src/test/functional/com/mongodb/connection/netty/NettyStreamSpecification.groovy
@jyemin jyemin requested a review from stIncMale October 20, 2023 19:36
stIncMale
stIncMale approved these changes Oct 21, 2023
View reviewed changes

@stIncMale stIncMale left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but the patch you linked has failed.

@jyemin

jyemin commented Oct 21, 2023

Copy link
Copy Markdown
Collaborator Author

https://spruce.mongodb.com/version/6532de605623439ac723f8e7/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC is good

@jyemin jyemin merged commit a42f1c8 into mongodb:5.x Oct 21, 2023
@jyemin jyemin deleted the j4937 branch October 21, 2023 00:38
jyemin added a commit that referenced this pull request Dec 4, 2023
@jyemin
Remove deprecated ServerAddress methods (#1224)
94c321f 
* ServerAddress#getSocketAddress
* ServerAddress#getSocketAddresses
* UnixServerAddress#getSocketAddress
* UnixServerAddress#getUnixSocketAddress

JAVA-4937
jyemin added a commit that referenced this pull request Dec 5, 2023
@jyemin
Remove deprecated ServerAddress methods (#1224)
0f98a73 
* ServerAddress#getSocketAddress
* ServerAddress#getSocketAddresses
* UnixServerAddress#getSocketAddress
* UnixServerAddress#getUnixSocketAddress

JAVA-4937
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stIncMale stIncMale stIncMale approved these changes

Assignees

@jyemin jyemin

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jyemin @stIncMale